Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isFullExitRequest return #8709

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fix isFullExitRequest return #8709

merged 2 commits into from
Oct 14, 2024

Conversation

jtraglia
Copy link
Contributor

@jtraglia jtraglia commented Oct 10, 2024

PR Description

When reviewing processWithdrawalRequests, I noticed two differences from the spec.

  • if is_full_exit_request: ... return
    • In Teku, this return statement was in the wrong spot. It would only return if we initiated the validator exit.
    • I believe this could have led to a more severe issue; maybe a consensus issue.
image
image

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@rolfyone rolfyone enabled auto-merge (squash) October 14, 2024 02:02
@rolfyone rolfyone merged commit c97b0c1 into Consensys:master Oct 14, 2024
17 checks passed
tbenr pushed a commit to zilm13/teku that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants